Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace LinkedList with ArrayDeque #2358

Merged
merged 1 commit into from
Feb 17, 2020
Merged

Replace LinkedList with ArrayDeque #2358

merged 1 commit into from
Feb 17, 2020

Conversation

3flex
Copy link
Member

@3flex 3flex commented Feb 17, 2020

This class is likely to be faster than Stack when used as a stack, and faster than LinkedList when used as a queue.

https://docs.oracle.com/javase/8/docs/api/java/util/ArrayDeque.html

ArrayDeque is likely to be faster.
@codecov-io
Copy link

codecov-io commented Feb 17, 2020

Codecov Report

Merging #2358 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2358   +/-   ##
=========================================
  Coverage     82.35%   82.35%           
  Complexity     2134     2134           
=========================================
  Files           349      349           
  Lines          6058     6058           
  Branches       1110     1110           
=========================================
  Hits           4989     4989           
  Misses          489      489           
  Partials        580      580
Impacted Files Coverage Δ Complexity Δ
...n/kotlin/io/gitlab/arturbosch/detekt/api/Config.kt 90% <100%> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7780548...bc844f4. Read the comment docs.

@schalkms schalkms merged commit e0c0720 into master Feb 17, 2020
@schalkms schalkms deleted the arraydeque branch February 17, 2020 06:35
@arturbosch arturbosch added this to the 1.6.0 milestone Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants