Skip to content

Sort and run correctable rules first - #2341 #2378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 3, 2020

Conversation

arturbosch
Copy link
Member

No description provided.

@arturbosch arturbosch marked this pull request as ready for review March 2, 2020 20:49
@arturbosch arturbosch added this to the 1.7.0 milestone Mar 2, 2020
@arturbosch arturbosch force-pushed the sort-and-run-correctable-rules-first branch from 3ef47ed to 0ecf9f1 Compare March 2, 2020 21:05
…ules/RuleSets.kt

Co-Authored-By: Brais Gabín <brais.gabin@adevinta.com>
@codecov-io
Copy link

codecov-io commented Mar 2, 2020

Codecov Report

Merging #2378 into master will increase coverage by 0.02%.
The diff coverage is 87.17%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2378      +/-   ##
============================================
+ Coverage     82.82%   82.85%   +0.02%     
- Complexity     2138     2141       +3     
============================================
  Files           352      352              
  Lines          6080     6107      +27     
  Branches       1109     1115       +6     
============================================
+ Hits           5036     5060      +24     
- Misses          475      476       +1     
- Partials        569      571       +2
Impacted Files Coverage Δ Complexity Δ
...in/kotlin/io/gitlab/arturbosch/detekt/core/Junk.kt 50% <ø> (-14.71%) 0 <0> (ø)
...io/gitlab/arturbosch/detekt/core/rules/RuleSets.kt 100% <100%> (ø) 0 <0> (ø) ⬇️
...otlin/io/gitlab/arturbosch/detekt/core/Detektor.kt 66.07% <80.76%> (+12.01%) 8 <2> (+3) ⬆️
...itlab/arturbosch/detekt/api/FileProcessListener.kt 75% <0%> (-25%) 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07a83d3...43b9eb5. Read the comment docs.

…etektor.kt

Co-Authored-By: Brais Gabín <brais.gabin@adevinta.com>
@arturbosch arturbosch merged commit aefe4e4 into master Mar 3, 2020
@arturbosch arturbosch deleted the sort-and-run-correctable-rules-first branch March 3, 2020 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants