-
-
Notifications
You must be signed in to change notification settings - Fork 783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discourage new Case files #2399
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2399 +/- ##
=========================================
Coverage 82.87% 82.87%
Complexity 2148 2148
=========================================
Files 353 353
Lines 6119 6119
Branches 1118 1118
=========================================
Hits 5071 5071
Misses 475 475
Partials 573 573 Continue to review full report at Codecov.
|
@@ -4,6 +4,8 @@ import io.gitlab.arturbosch.detekt.test.resource | |||
import java.nio.file.Path | |||
import java.nio.file.Paths | |||
|
|||
/* Do not add new elements to this file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets encourage the usage of inline snippets here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with Artur.
Furthermore, we should also strive to inline the case files when we change something in a rule or in the corresponding spec file, which still links a case file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also try to mention this in PR reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've reworded, hopefully the updated text is OK?
Closes #1089
That issue will remain open until all case files are retired, which may take a long time as it's quite a thankless task - instead, add a comment asking contributors not to add new case files with a reference to the PR so the PR can be closed.