Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ExplicitCollectionElementAccessMethod: Don't report on nullable collection #2401

Merged
merged 2 commits into from
Mar 4, 2020
Merged

ExplicitCollectionElementAccessMethod: Don't report on nullable collection #2401

merged 2 commits into from
Mar 4, 2020

Conversation

xouabita
Copy link
Contributor

@xouabita xouabita commented Mar 4, 2020

Should fix #2391

@xouabita xouabita marked this pull request as ready for review March 4, 2020 17:00
schalkms
schalkms approved these changes Mar 4, 2020
View reviewed changes
Copy link
Member

@schalkms schalkms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@schalkms schalkms merged commit cca9459 into detekt:master Mar 4, 2020
@arturbosch arturbosch added this to the 1.7.0 milestone Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schalkms schalkms schalkms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.

ExplicitCollectionElementAccessMethod: Do not report map?.get("foo")
3 participants
@xouabita @schalkms @arturbosch