Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only post a code coverage patch status to PRs #2402

Merged
merged 1 commit into from
Mar 5, 2020
Merged

Only post a code coverage patch status to PRs #2402

merged 1 commit into from
Mar 5, 2020

Conversation

schalkms
Copy link
Member

@schalkms schalkms commented Mar 4, 2020

This affects the codecov coverage reports.
Patch coverage reports should only run on PRs.
It provides information concerning how well the changes made in a PR were tested.
Previously, many patch reports have failed already merged PRs on the master branch.
The total coverage is not affected by this commit.
See:
https://docs.codecov.io/docs/commit-status#section-only-pulls

This affects the codecov coverage reports.
Patch coverage reports should only run on PRs.
It provides information concerning how well the changes made in a PR were tested.
Previously, many patch reports have failed already merged PRs on the master branch.
The total coverage is not affected by this commit.
See:
https://docs.codecov.io/docs/commit-status#section-only-pulls
@codecov-io
Copy link

codecov-io commented Mar 4, 2020

Codecov Report

Merging #2402 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2402      +/-   ##
============================================
+ Coverage     82.87%   82.88%   +0.01%     
+ Complexity     2148     2147       -1     
============================================
  Files           353      353              
  Lines          6119     6123       +4     
  Branches       1118     1116       -2     
============================================
+ Hits           5071     5075       +4     
  Misses          475      475              
  Partials        573      573
Impacted Files Coverage Δ Complexity Δ
.../arturbosch/detekt/rules/style/UnnecessaryApply.kt 79.31% <0%> (-1.94%) 6% <0%> (ø)
...les/style/ExplicitCollectionElementAccessMethod.kt 90.32% <0%> (-0.31%) 16% <0%> (-1%)
...n/io/gitlab/arturbosch/detekt/rules/LinesOfCode.kt 100% <0%> (ø) 0% <0%> (ø) ⬇️
...ain/kotlin/io/gitlab/arturbosch/detekt/api/Debt.kt 100% <0%> (ø) 6% <0%> (ø) ⬇️
...b/arturbosch/detekt/cli/FilteredDetectionResult.kt 100% <0%> (ø) 2% <0%> (ø) ⬇️
...itlab/arturbosch/detekt/core/ProcessingSettings.kt 90.62% <0%> (+0.14%) 18% <0%> (ø) ⬇️
...n/io/gitlab/arturbosch/detekt/cli/out/XmlEscape.kt 64.28% <0%> (+0.25%) 3% <0%> (ø) ⬇️
...rturbosch/detekt/formatting/OffsetsToLineColumn.kt 82.14% <0%> (+0.66%) 0% <0%> (ø) ⬇️
...in/kotlin/io/gitlab/arturbosch/detekt/api/Issue.kt 87.5% <0%> (+1.78%) 5% <0%> (ø) ⬇️
...b/arturbosch/detekt/api/internal/DetektPomModel.kt 68.75% <0%> (+2.08%) 5% <0%> (ø) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9bb93e...b9638e1. Read the comment docs.

@arturbosch arturbosch merged commit 56853b2 into detekt:master Mar 5, 2020
@arturbosch arturbosch added this to the 1.7.0 milestone Mar 5, 2020
@schalkms schalkms deleted the codecov-patch branch March 8, 2020 10:43
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants