Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable autoCorrect property for all rules if global flag is set to false #2413

Merged
merged 2 commits into from
Mar 6, 2020

Conversation

arturbosch
Copy link
Member

Closes #2341

This way we make sure no KtFile is modified and our reporting calculates the right issue locations.

…alse - #2341

This way we make sure no KtFile is modified and our reporting calculates the right issue locations.
@arturbosch arturbosch added this to the 1.7.0 milestone Mar 5, 2020
@codecov-io
Copy link

codecov-io commented Mar 5, 2020

Codecov Report

Merging #2413 into master will increase coverage by 0.01%.
The diff coverage is 81.81%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2413      +/-   ##
============================================
+ Coverage     82.88%   82.89%   +0.01%     
- Complexity     2147     2157      +10     
============================================
  Files           353      354       +1     
  Lines          6123     6134      +11     
  Branches       1116     1120       +4     
============================================
+ Hits           5075     5085      +10     
  Misses          475      475              
- Partials        573      574       +1
Impacted Files Coverage Δ Complexity Δ
.../io/gitlab/arturbosch/detekt/cli/Configurations.kt 78.78% <100%> (+1.36%) 0 <0> (ø) ⬇️
...h/detekt/api/internal/DisabledAutoCorrectConfig.kt 77.77% <77.77%> (ø) 7 <7> (?)
...ain/kotlin/io/gitlab/arturbosch/detekt/api/Rule.kt 94.11% <0%> (+5.88%) 17% <0%> (+2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3481ae7...65279fa. Read the comment docs.

@arturbosch
Copy link
Member Author

@schalkms @BraisGabin I will leave this one for you to merge so we can verify if #2412 was a one time GitHub error.

@schalkms schalkms merged commit b513df4 into master Mar 6, 2020
@schalkms schalkms deleted the force-no-auto-correct branch March 6, 2020 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mixing autocorrectable and non correctable rules results in obsolete issue locations for reports
4 participants