Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate implementations of Config #2420

Merged
merged 2 commits into from
Mar 9, 2020
Merged

Deprecate implementations of Config #2420

merged 2 commits into from
Mar 9, 2020

Conversation

arturbosch
Copy link
Member

@arturbosch arturbosch commented Mar 8, 2020

Rule authors do not need to know about internal implementations of YamlConfig etc.
They know that the yaml format config is supported and what methods can be used with a Config object.

#2365

@arturbosch arturbosch added this to the 1.7.0 milestone Mar 8, 2020
Rule authors do not need to know about internal implementations of YamlConfig etc.
They know that the yaml format config is supported and what methods can be used with a Config object.
@codecov-io
Copy link

Codecov Report

Merging #2420 into master will decrease coverage by 0.01%.
The diff coverage is 80.3%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2420      +/-   ##
============================================
- Coverage     82.87%   82.85%   -0.02%     
- Complexity     2157     2174      +17     
============================================
  Files           354      356       +2     
  Lines          6136     6137       +1     
  Branches       1122     1121       -1     
============================================
  Hits           5085     5085              
- Misses          475      476       +1     
  Partials        576      576
Impacted Files Coverage Δ Complexity Δ
...ch/detekt/api/internal/ValidatableConfiguration.kt 100% <ø> (ø) 0 <0> (ø) ⬇️
.../io/gitlab/arturbosch/detekt/cli/Configurations.kt 78.78% <ø> (ø) 0 <0> (ø) ⬇️
...n/kotlin/io/gitlab/arturbosch/detekt/api/Config.kt 93.75% <ø> (+3.75%) 0 <0> (ø) ⬇️
.../arturbosch/detekt/api/internal/CompositeConfig.kt 66.66% <66.66%> (ø) 5 <5> (?)
...itlab/arturbosch/detekt/api/internal/YamlConfig.kt 76.92% <76.92%> (ø) 8 <8> (?)
...tlab/arturbosch/detekt/api/internal/EmptyConfig.kt 83.33% <83.33%> (ø) 5 <5> (?)
...itlab/arturbosch/detekt/api/internal/BaseConfig.kt 85.71% <85.71%> (ø) 12 <12> (?)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd45144...7ca844c. Read the comment docs.

@arturbosch arturbosch merged commit 79fc19d into master Mar 9, 2020
@arturbosch arturbosch deleted the deprecate-configs branch March 9, 2020 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants