Add Groovy DSL example for jvmTarget to homepage #2423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This complies with the source code in the README. follow-up task to #2422
Codecov Report
@@ Coverage Diff @@
## master #2423 +/- ##
=========================================
Coverage 82.87% 82.87%
Complexity 2157 2157
=========================================
Files 354 354
Lines 6136 6136
Branches 1122 1122
=========================================
Hits 5085 5085
Misses 475 475
Partials 576 576Continue to review full report at Codecov.
|
arturbosch
approved these changes
Mar 9, 2020
cortinico
reviewed
Mar 9, 2020
| @@ -118,10 +118,7 @@ Type resolution is experimental and works only for predefined `detektMain` and ` | |||
| custom detekt task with the `classpath` and `jvmTarget` properties present. | |||
There was a problem hiding this comment.
Should this line be updated as well (as the snippet is missing the classpath specification)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This complies with the source code in the README.
follow-up task to #2422