Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Choose a minimum codecov patch coverage ratio #2425

Merged
merged 1 commit into from
Mar 9, 2020
Merged

Choose a minimum codecov patch coverage ratio #2425

merged 1 commit into from
Mar 9, 2020

Conversation

schalkms
Copy link
Member

@schalkms schalkms commented Mar 9, 2020

Chooses a minimum patch coverage ratio that the commit must meet to be considered a success.
This applies only to PRs.

Docs:
https://docs.codecov.io/docs/commit-status

Copy link
Member Author

@schalkms schalkms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some PRs have been failing because the patch coverage only slightly dropped compared with our current ratio, which is ~83 %.
I think 80 % is a good value for the patch test coverage of a PR.

Chooses a minimum patch coverage ratio that the commit must meet to be considered a success.
This applies only to PRs.

Docs:
https://docs.codecov.io/docs/commit-status
@codecov-io
Copy link

codecov-io commented Mar 9, 2020

Codecov Report

Merging #2425 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2425   +/-   ##
=========================================
  Coverage     82.87%   82.87%           
  Complexity     2157     2157           
=========================================
  Files           354      354           
  Lines          6136     6136           
  Branches       1122     1122           
=========================================
  Hits           5085     5085           
  Misses          475      475           
  Partials        576      576

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2237b0f...7188c20. Read the comment docs.

@arturbosch arturbosch merged commit 1857ff0 into detekt:master Mar 9, 2020
@arturbosch arturbosch added this to the 1.7.0 milestone Mar 9, 2020
@schalkms schalkms deleted the codecov-patch-target branch March 9, 2020 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants