-
-
Notifications
You must be signed in to change notification settings - Fork 783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fail if --baseline
file not found
#2427
Fail if --baseline
file not found
#2427
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2427 +/- ##
============================================
+ Coverage 82.83% 82.87% +0.03%
- Complexity 2166 2171 +5
============================================
Files 356 356
Lines 6136 6142 +6
Branches 1119 1122 +3
============================================
+ Hits 5083 5090 +7
Misses 478 478
+ Partials 575 574 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the test case description could be improved to be more fluent.
For instance:
it(fails with —baseline if the file does not exist)
I just changed the test descriptions |
detekt-cli/src/test/kotlin/io/gitlab/arturbosch/detekt/cli/MainSpec.kt
Outdated
Show resolved
Hide resolved
detekt-cli/src/test/kotlin/io/gitlab/arturbosch/detekt/cli/MainSpec.kt
Outdated
Show resolved
Hide resolved
…nSpec.kt Co-Authored-By: M Schalk <30376729+schalkms@users.noreply.github.com>
…nSpec.kt Co-Authored-By: M Schalk <30376729+schalkms@users.noreply.github.com>
Close #2374
Check that the file set by
--baseline
exists and is not a folder.