Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail if --baseline file not found #2427

Merged
merged 4 commits into from
Mar 10, 2020
Merged

Fail if --baseline file not found #2427

merged 4 commits into from
Mar 10, 2020

Conversation

BraisGabin
Copy link
Member

Close #2374

Check that the file set by --baseline exists and is not a folder.

@codecov-io
Copy link

codecov-io commented Mar 9, 2020

Codecov Report

Merging #2427 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2427      +/-   ##
============================================
+ Coverage     82.83%   82.87%   +0.03%     
- Complexity     2166     2171       +5     
============================================
  Files           356      356              
  Lines          6136     6142       +6     
  Branches       1119     1122       +3     
============================================
+ Hits           5083     5090       +7     
  Misses          478      478              
+ Partials        575      574       -1
Impacted Files Coverage Δ Complexity Δ
...ain/kotlin/io/gitlab/arturbosch/detekt/cli/Main.kt 53.12% <100%> (+14.66%) 12 <0> (+5) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62d7dd7...7b1a57a. Read the comment docs.

@arturbosch arturbosch added this to the 1.7.0 milestone Mar 10, 2020
Copy link
Member

@schalkms schalkms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the test case description could be improved to be more fluent.
For instance:
it(fails with —baseline if the file does not exist)

@BraisGabin
Copy link
Member Author

I just changed the test descriptions

BraisGabin and others added 2 commits March 10, 2020 21:02
…nSpec.kt

Co-Authored-By: M Schalk <30376729+schalkms@users.noreply.github.com>
…nSpec.kt

Co-Authored-By: M Schalk <30376729+schalkms@users.noreply.github.com>
@schalkms schalkms merged commit f205bcd into detekt:master Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should fail if --baseline file does not found?
4 participants