Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LateInitUsage: One annotation match is enough to let the property be ignored. #245

Merged
merged 1 commit into from Jul 28, 2017
Merged

LateInitUsage: One annotation match is enough to let the property be ignored. #245

merged 1 commit into from Jul 28, 2017

Conversation

vanniktech
Copy link
Contributor

@vanniktech vanniktech commented Jul 26, 2017 •
edited

Fixes #241

arturbosch
arturbosch reviewed Jul 27, 2017
View reviewed changes
detekt-rules/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/bugs/LateinitUsage.kt Outdated
.none { annotationFqn ->
excludeAnnotatedProperties.none(annotationFqn)
}
.count { !excludeAnnotatedProperties.none(it) } > 0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't there something like firstMatch ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not that I'm aware of

arturbosch
arturbosch reviewed Jul 27, 2017
View reviewed changes
Copy link
Member

@arturbosch arturbosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any is the function you want

@vanniktech
Copy link
Contributor Author

Updated.

@arturbosch arturbosch merged commit 2b07542 into detekt:master Jul 28, 2017
@vanniktech vanniktech deleted the fix241 branch July 28, 2017 08:17
@arturbosch arturbosch modified the milestone: RC1 Jul 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arturbosch arturbosch arturbosch left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
RC1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vanniktech @arturbosch