Fix toString() output for Whitelist class #2459
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BraisGabin
reviewed
Mar 19, 2020
| @@ -5,6 +5,6 @@ data class Whitelist( | |||
| ) : Listing<Whitelist> { | |||
|
|
|||
| override fun toString(): String { | |||
| return "Blacklist(ids=$ids)" | |||
| return "Whitelist(ids=$ids)" | |||
| } | |||
There was a problem hiding this comment.
This is a data class, can't we use the default toString? If the answer is no, we should add a simple test here to ensure that no one removes it in the future.
There was a problem hiding this comment.
Good point
data class Whitelist(
override val ids: Set<String>
) : Listing<Whitelist>
fun main() {
println(Whitelist(setOf("1", "2"))) // Whitelist(ids=[1, 2])
}It actually prints the same string :)
arturbosch
requested changes
Mar 19, 2020
| @@ -5,6 +5,6 @@ data class Whitelist( | |||
| ) : Listing<Whitelist> { | |||
|
|
|||
| override fun toString(): String { | |||
| return "Blacklist(ids=$ids)" | |||
| return "Whitelist(ids=$ids)" | |||
| } | |||
There was a problem hiding this comment.
Good point
data class Whitelist(
override val ids: Set<String>
) : Listing<Whitelist>
fun main() {
println(Whitelist(setOf("1", "2"))) // Whitelist(ids=[1, 2])
}It actually prints the same string :)
|
see #2467 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.