Validate boolean config values - Closes #2045 #2465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arturbosch
commented
Mar 19, 2020
detekt-api/src/main/kotlin/io/gitlab/arturbosch/detekt/api/internal/BaseConfig.kt
Outdated
Show resolved
Hide resolved
BraisGabin
reviewed
Mar 19, 2020
detekt-api/src/main/kotlin/io/gitlab/arturbosch/detekt/api/internal/BaseConfig.kt
Show resolved
Hide resolved
detekt-api/src/main/kotlin/io/gitlab/arturbosch/detekt/api/internal/BaseConfig.kt
Outdated
Show resolved
Hide resolved
BraisGabin
approved these changes
Mar 19, 2020
detekt-api/src/main/kotlin/io/gitlab/arturbosch/detekt/api/internal/BaseConfig.kt
Outdated
Show resolved
Hide resolved
arturbosch
force-pushed
the
validate-bools
branch
from
33420ed
to
587769a
Compare
Co-Authored-By: Brais Gabín <braisgabin@gmail.com>
arturbosch
force-pushed
the
validate-bools
branch
from
587769a
to
924f1f1
Compare
Codecov Report
@@ Coverage Diff @@
## master #2465 +/- ##
============================================
+ Coverage 83.2% 83.22% +0.01%
- Complexity 2182 2183 +1
============================================
Files 359 359
Lines 6206 6210 +4
Branches 1138 1139 +1
============================================
+ Hits 5164 5168 +4
Misses 467 467
Partials 575 575
Continue to review full report at Codecov.
|
schalkms
approved these changes
Mar 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.