Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use yml arrays to list the ForbiddenImports #2474

Merged
merged 3 commits into from
Mar 22, 2020

Conversation

BraisGabin
Copy link
Member

Fixes #2463

I think that we should add this to the rest of configurations that have lists and deprecate the strings splitted by ,. And remove the support in 2.0. My reasons:

  • It's easier to mantain the configuration using lists than strings
  • We don't need to handle strange cases splitting strings (empty strings and similar)

If you agree I can open an issue to track all those configurations.

@arturbosch arturbosch modified the milestones: 1.7.0, 1.7.1 Mar 21, 2020
@codecov-io
Copy link

codecov-io commented Mar 22, 2020

Codecov Report

Merging #2474 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master   #2474      +/-   ##
===========================================
+ Coverage     83.29%   83.3%   +0.01%     
  Complexity     2196    2196              
===========================================
  Files           360     360              
  Lines          6225    6230       +5     
  Branches       1144    1144              
===========================================
+ Hits           5185    5190       +5     
  Misses          463     463              
  Partials        577     577
Impacted Files Coverage Δ Complexity Δ
...n/kotlin/io/gitlab/arturbosch/detekt/rules/Junk.kt 68.75% <100%> (+18.75%) 0 <0> (ø) ⬇️
...b/arturbosch/detekt/rules/style/ForbiddenImport.kt 94.73% <100%> (-0.27%) 9 <0> (ø)
...turbosch/detekt/rules/style/ForbiddenMethodCall.kt 86.66% <100%> (ø) 5 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e40e53...e840371. Read the comment docs.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use yml arrays to list the ForbiddenImports
4 participants