Minor refactors around --create-baseline #2477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2477 +/- ##
===========================================
+ Coverage 83.29% 83.3% +0.01%
+ Complexity 2185 2184 -1
===========================================
Files 360 360
Lines 6207 6206 -1
Branches 1139 1137 -2
===========================================
Hits 5170 5170
Misses 463 463
+ Partials 574 573 -1
Continue to review full report at Codecov.
|
arturbosch
approved these changes
Mar 21, 2020
| "--create-baseline", | ||
| "--report", "txt:$tmpReport", | ||
| "--config-resource", "/configs/max-issues-0.yml" | ||
| )) | ||
|
|
||
| Runner(cliArgs).execute() | ||
|
|
||
| assertThat(Files.readAllLines(tmpReport)).hasSize(1) | ||
| assertThat(tmpReport).hasContent("") |
arturbosch
reviewed
Mar 21, 2020
| "--create-baseline", | ||
| "--report", "txt:$tmpReport", | ||
| "--config-resource", "/configs/max-issues-0.yml" | ||
| )) | ||
|
|
||
| Runner(cliArgs).execute() | ||
|
|
||
| assertThat(Files.readAllLines(tmpReport)).hasSize(1) |
There was a problem hiding this comment.
I think it was just the newline ending asserted here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please, check the second commit carefully. I think that the test was wrong, but I'm not 100% sure.