Simplify tests with StringPrintStream #2487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arturbosch
reviewed
Mar 22, 2020
|
|
||
| class StringPrintStream private constructor( | ||
| private val stream: ByteArrayOutputStream | ||
| ) : PrintStream(stream) { |
There was a problem hiding this comment.
All usages should probably close this stream at the end.
Lets implement AutoCloseable and close the stream here ?
arturbosch
approved these changes
Mar 22, 2020
|
We don't really need to close this one. It doesn't hold any resource, it's all in memory. |
Codecov Report
@@ Coverage Diff @@
## master #2487 +/- ##
=========================================
Coverage 83.26% 83.26%
Complexity 2198 2198
=========================================
Files 360 360
Lines 6240 6240
Branches 1144 1144
=========================================
Hits 5196 5196
Misses 466 466
Partials 578 578 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.