ProcessingSettings #2489
Merged
ProcessingSettings #2489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arturbosch
reviewed
Mar 23, 2020
detekt-core/src/main/kotlin/io/gitlab/arturbosch/detekt/core/ProcessingSettings.kt
Show resolved
Hide resolved
arturbosch
approved these changes
Mar 23, 2020
This force us to set the printer manually so we can set a NullPrintStream in the tests and make them less noisy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the third of a serie of PRs related with how we manage the output.
The main ideas:
PrinterStream.printlninstead ofprintlnprinterStream. Because that is the same as useprintln.PrinterStreamto print output we can useNullPrinterStreamor other types ofPrinterStreamso we don't print to the stdout when we run tests. With this we can reduce the log size related with tests about 40%.