Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MemberNameEqualsClassName: fix false negative when function has no explicit return type #2502

Merged
merged 1 commit into from
Mar 24, 2020

Conversation

t-kameyama
Copy link
Contributor

Fixes #655

@codecov-io
Copy link

codecov-io commented Mar 24, 2020

Codecov Report

Merging #2502 into master will increase coverage by 0.02%.
The diff coverage is 88.88%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2502      +/-   ##
============================================
+ Coverage     80.03%   80.05%   +0.02%     
- Complexity     2255     2257       +2     
============================================
  Files           378      378              
  Lines          6621     6628       +7     
  Branches       1176     1178       +2     
============================================
+ Hits           5299     5306       +7     
  Misses          740      740              
  Partials        582      582
Impacted Files Coverage Δ Complexity Δ
...h/detekt/rules/naming/MemberNameEqualsClassName.kt 90.9% <88.88%> (+2.44%) 16 <2> (+2) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc620d1...9d0c773. Read the comment docs.

Copy link
Member

@schalkms schalkms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing another awesome fix!
Great work again! I'm waiting a few hours for a second look over this PR.
Then I'd say LGTM! :-)

@schalkms schalkms merged commit 2c929e1 into detekt:master Mar 24, 2020
@t-kameyama t-kameyama deleted the issue_655 branch March 24, 2020 13:24
@arturbosch arturbosch added this to the 1.7.1 milestone Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MemberNameEqualsClassName ignores functions which return a single expression
5 participants