Ensure filesystems are created so paths can be gotten #2504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arturbosch
reviewed
Mar 24, 2020
| @@ -78,5 +79,10 @@ fun CliArgs.extractUris(): Collection<URI> { | |||
| val pathUris = config?.let { MultipleExistingPathConverter().convert(it).map(Path::toUri) } ?: emptyList() | |||
| val resourceUris = configResource?.let { MultipleClasspathResourceConverter().convert(it).map(URL::toURI) } | |||
| ?: emptyList() | |||
| resourceUris.forEach { | |||
| runCatching { | |||
| FileSystems.newFileSystem(it, emptyMap<String, Any>()) | |||
There was a problem hiding this comment.
Thanks for analyzing this issue!
I would prefer the second answer on stackoverflow
private FileSystem initFileSystem(URI uri) throws IOException
{
try
{
return FileSystems.getFileSystem(uri);
}
catch( FileSystemNotFoundException e )
{
Map<String, String> env = new HashMap<>();
env.put("create", "true");
return FileSystems.newFileSystem(uri, env);
}
}Your code could be refactored to resourceUris.forEach(checkFileSystem).
The create=true part sounds to be important.
josephlbarnett
force-pushed
the
filesystem-creation
branch
2 times, most recently
from
12ae0ad to
5637d6f
Compare
schalkms
approved these changes
Mar 24, 2020
josephlbarnett
force-pushed
the
filesystem-creation
branch
from
5637d6f to
3e69c10
Compare
When getting resources from the classpath, the ZipFileSystem needs to be initialized manually. Fixes detekt#2503
josephlbarnett
force-pushed
the
filesystem-creation
branch
from
3e69c10 to
4f55636
Compare
Codecov Report
@@ Coverage Diff @@
## master #2504 +/- ##
============================================
- Coverage 80.07% 80.04% -0.03%
Complexity 2257 2257
============================================
Files 378 378
Lines 6635 6641 +6
Branches 1180 1180
============================================
+ Hits 5313 5316 +3
- Misses 740 743 +3
Partials 582 582
Continue to review full report at Codecov.
|
@arturbosch this should be included in v1.7.1 in my opinion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When getting resources from the classpath, the ZipFileSystem
needs to be initialized manually.
Fixes #2503