Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LicenceHeaderExtension test to verify resource path loading is supported #2505

Merged
merged 1 commit into from
Mar 24, 2020

Conversation

arturbosch
Copy link
Member

@arturbosch arturbosch added this to the 1.8.0 milestone Mar 24, 2020
Copy link
Member

@schalkms schalkms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is quite a serious bug.
Does it require a new patch version in your opinion?

@josephlbarnett
Copy link
Contributor

is it surprising that this test seems to pass without #2504 in the branch?

@arturbosch
Copy link
Member Author

Yep, it is suprising. Maybe Junit5 creates it upfront.
@schalkms yep, our current 1.8 PR's are all internal refactorings. Releasing is cheap.
Lets also update to Kotlin 1.3.71 :)

@arturbosch arturbosch merged commit 8ac3b39 into master Mar 24, 2020
@arturbosch arturbosch deleted the licence-header-extension-test branch March 24, 2020 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants