Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UnnecessaryAbstractClass: fix false positive when abstract class has abstract inherited members #2513

Merged
merged 1 commit into from
Mar 26, 2020
Merged

UnnecessaryAbstractClass: fix false positive when abstract class has abstract inherited members #2513

merged 1 commit into from
Mar 26, 2020

Conversation

t-kameyama
Copy link
Contributor

Fixes #727

arturbosch
arturbosch approved these changes Mar 26, 2020
View reviewed changes
Copy link
Member

@arturbosch arturbosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the great PR which is also backwards compatible when classpath is not provided!
I will merge this PR now for the new release.
Please note that we try to migrate away from the Case test cases to inline string scripts.

@arturbosch arturbosch added this to the 1.7.1 milestone Mar 26, 2020
@arturbosch arturbosch merged commit 85c1338 into detekt:master Mar 26, 2020
@t-kameyama t-kameyama deleted the issue727 branch March 26, 2020 15:13
@schalkms schalkms mentioned this pull request Mar 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arturbosch arturbosch arturbosch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.7.1
Development

Successfully merging this pull request may close these issues.

False positive on rule UnnecessaryAbstractClass
2 participants
@t-kameyama @arturbosch