Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor build file to sections #2541

Merged
merged 4 commits into from
Mar 28, 2020
Merged

Refactor build file to sections #2541

merged 4 commits into from
Mar 28, 2020

Conversation

arturbosch
Copy link
Member

No description provided.

@arturbosch arturbosch added this to the 1.7.2 milestone Mar 28, 2020
@codecov-io
Copy link

codecov-io commented Mar 28, 2020

Codecov Report

Merging #2541 into master will decrease coverage by 55.65%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             master    #2541       +/-   ##
=============================================
- Coverage     80.83%   25.18%   -55.66%     
+ Complexity     2265      392     -1873     
=============================================
  Files           376      376               
  Lines          7353     7353               
  Branches       1206     1206               
=============================================
- Hits           5944     1852     -4092     
- Misses          810     5370     +4560     
+ Partials        599      131      -468     
Impacted Files Coverage Δ Complexity Δ
...tlin/io/gitlab/arturbosch/detekt/cli/ReportPath.kt 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-1.00%)
...in/io/gitlab/arturbosch/detekt/api/Notification.kt 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (ø%)
...n/io/gitlab/arturbosch/detekt/rules/LinesOfCode.kt 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (ø%)
.../gitlab/arturbosch/detekt/cli/baseline/Baseline.kt 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-1.00%)
...io/gitlab/arturbosch/detekt/rules/IsPartOfUtils.kt 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (ø%)
...gitlab/arturbosch/detekt/cli/baseline/Blacklist.kt 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-2.00%)
...gitlab/arturbosch/detekt/cli/baseline/Whitelist.kt 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-2.00%)
...gitlab/arturbosch/detekt/cli/runners/AstPrinter.kt 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-4.00%)
...b/arturbosch/detekt/cli/FilteredDetectionResult.kt 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-2.00%)
...rbosch/detekt/cli/baseline/InvalidBaselineState.kt 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-1.00%)
... and 326 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48577be...40c51d5. Read the comment docs.

@arturbosch
Copy link
Member Author

Codecov gets triggered before any report can be published?

@arturbosch arturbosch modified the milestones: 1.7.2, 1.8.0 Mar 28, 2020
@schalkms
Copy link
Member

@arturbosch maybe because of the old setting removed in #2546 ?

Copy link
Member

@BraisGabin BraisGabin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏👏👏👏

build.gradle.kts Show resolved Hide resolved
@arturbosch arturbosch merged commit 8a48551 into master Mar 28, 2020
@arturbosch arturbosch deleted the refactor-build-file branch March 28, 2020 20:15
@schalkms
Copy link
Member

Coverage went down to 25% 😐

@arturbosch
Copy link
Member Author

And some of the newer PRs increase it by x.xx% without writing tests :S

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants