Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix console output indentation #2552

Merged
merged 4 commits into from
Mar 31, 2020
Merged

Conversation

BraisGabin
Copy link
Member

Fixes #2551

This PR changes this:
Captura de pantalla 2020-03-29 a las 15 31 37

to this:
Captura de pantalla 2020-03-29 a las 15 52 21

Any idea about how to test this? Because I don't really know why this code works and the other don't...

I tested this with zsh and bash.

@codecov-io
Copy link

codecov-io commented Mar 29, 2020

Codecov Report

Merging #2552 into master will decrease coverage by 1.71%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2552      +/-   ##
============================================
- Coverage     26.89%   25.17%   -1.72%     
- Complexity      390      392       +2     
============================================
  Files           377      377              
  Lines          6671     7371     +700     
  Branches       1207     1208       +1     
============================================
+ Hits           1794     1856      +62     
- Misses         4746     5384     +638     
  Partials        131      131              
Impacted Files Coverage Δ Complexity Δ
.../arturbosch/detekt/cli/console/ComplexityReport.kt 23.07% <0.00%> (-4.20%) 3.00 <0.00> (ø)
.../arturbosch/detekt/cli/console/ReportFormatting.kt 0.00% <0.00%> (-6.67%) 0.00 <0.00> (ø)
...osch/detekt/cli/console/ProjectStatisticsReport.kt 92.30% <100.00%> (+2.30%) 3.00 <0.00> (ø)
...ab/arturbosch/detekt/rules/empty/EmptyInitBlock.kt 33.33% <0.00%> (-16.67%) 1.00% <0.00%> (ø%)
...ch/detekt/rules/empty/EmptySecondaryConstructor.kt 33.33% <0.00%> (-16.67%) 1.00% <0.00%> (ø%)
...t/rules/exceptions/ThrowingExceptionFromFinally.kt 50.00% <0.00%> (-16.67%) 1.00% <0.00%> (ø%)
...tekt/core/processors/ProjectComplexityProcessor.kt 50.00% <0.00%> (-12.50%) 2.00% <0.00%> (ø%)
...sch/detekt/core/processors/KtFileCountProcessor.kt 71.42% <0.00%> (-11.91%) 2.00% <0.00%> (ø%)
...detekt/rules/bugs/ExplicitGarbageCollectionCall.kt 31.25% <0.00%> (-10.42%) 2.00% <0.00%> (ø%)
...itlab/arturbosch/detekt/rules/empty/EmptyBlocks.kt 41.55% <0.00%> (-10.06%) 1.00% <0.00%> (ø%)
... and 259 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21ea090...b12d5d0. Read the comment docs.

Copy link
Member

@arturbosch arturbosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you inline the other format and PREFIX usages, we can get rid of these declarations 👍

@arturbosch arturbosch added this to the 1.8.0 milestone Mar 29, 2020
@BraisGabin
Copy link
Member Author

@arturbosch done. I inlined all the uses of both of them. Doing so I found a little improvement and I fixed it directly in this PR. For that reason I'm requesting the review again.

@arturbosch arturbosch merged commit 91fdc64 into detekt:master Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Console output is not indented correctly
4 participants