Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include statistics for our custom detekt tasks #2554

Merged
merged 2 commits into from
Mar 31, 2020
Merged

Include statistics for our custom detekt tasks #2554

merged 2 commits into from
Mar 31, 2020

Conversation

arturbosch
Copy link
Member

@arturbosch arturbosch commented Mar 29, 2020 •
edited
Loading

Also detektFormat finds more issues with detekt-formatting than the Gradle task for each sub module ... I guess the bug reports are real :D

@arturbosch arturbosch added this to the 1.8.0 milestone Mar 29, 2020
@schalkms
Copy link
Member

Also detektFormat finds more issues with detekt-formatting than the Gradle task for each sub module ... I guess the bug reports are real :D

:-/

BraisGabin
BraisGabin approved these changes Mar 31, 2020
View reviewed changes
Copy link
Member

@BraisGabin BraisGabin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea what these changes do. And I don't know which bugs you are refering in the description. Do you mean that detektFormat fixes things that detekt doesn't flag?

@arturbosch
Copy link
Member Author

arturbosch commented Mar 31, 2020 •
edited
Loading

I have no idea what these changes do. And I don't know which bugs you are refering in the description. Do you mean that detektFormat fixes things that detekt doesn't flag?

Oh, I just turned off the "silent mode" on the custom tasks like detektFormat and detektAll.
Yes, detektFormat finds issues which just detekt does not report. We have some open bug tickets for detekt-formatting. I was just noticing that apparently they are real and need some attention :)

Thanks!

@arturbosch arturbosch merged commit 06260b1 into master Mar 31, 2020
@arturbosch arturbosch deleted the statistics branch March 31, 2020 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BraisGabin BraisGabin BraisGabin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.7.3
Development

Successfully merging this pull request may close these issues.
3 participants
@arturbosch @schalkms @BraisGabin