Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display actual and threshold values for several metric rules #2559

Merged
merged 1 commit into from
Mar 30, 2020
Merged

Display actual and threshold values for several metric rules #2559

merged 1 commit into from
Mar 30, 2020

Conversation

swsms
Copy link
Contributor

@swsms swsms commented Mar 30, 2020

Display actual values and threshold values for several metric rules.
The text is similar to this one.

@codecov-io
Copy link

codecov-io commented Mar 30, 2020

Codecov Report

Merging #2559 into master will decrease coverage by 1.72%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2559      +/-   ##
============================================
- Coverage     26.89%   25.16%   -1.73%     
- Complexity      390      392       +2     
============================================
  Files           377      377              
  Lines          6671     7367     +696     
  Branches       1207     1208       +1     
============================================
+ Hits           1794     1854      +60     
- Misses         4746     5382     +636     
  Partials        131      131              
Impacted Files Coverage Δ Complexity Δ
...rbosch/detekt/rules/complexity/ComplexCondition.kt 17.07% <0.00%> (-2.38%) 3.00 <0.00> (ø)
...rturbosch/detekt/rules/complexity/ComplexMethod.kt 37.50% <0.00%> (-4.17%) 3.00 <0.00> (ø)
...b/arturbosch/detekt/rules/complexity/LongMethod.kt 27.02% <0.00%> (-3.28%) 3.00 <0.00> (ø)
...ab/arturbosch/detekt/rules/empty/EmptyInitBlock.kt 33.33% <0.00%> (-16.67%) 1.00% <0.00%> (ø%)
...ch/detekt/rules/empty/EmptySecondaryConstructor.kt 33.33% <0.00%> (-16.67%) 1.00% <0.00%> (ø%)
...t/rules/exceptions/ThrowingExceptionFromFinally.kt 50.00% <0.00%> (-16.67%) 1.00% <0.00%> (ø%)
...tekt/core/processors/ProjectComplexityProcessor.kt 50.00% <0.00%> (-12.50%) 2.00% <0.00%> (ø%)
...sch/detekt/core/processors/KtFileCountProcessor.kt 71.42% <0.00%> (-11.91%) 2.00% <0.00%> (ø%)
...detekt/rules/bugs/ExplicitGarbageCollectionCall.kt 31.25% <0.00%> (-10.42%) 2.00% <0.00%> (ø%)
...itlab/arturbosch/detekt/rules/empty/EmptyBlocks.kt 41.55% <0.00%> (-10.06%) 1.00% <0.00%> (ø%)
... and 260 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21ea090...a6d06f1. Read the comment docs.

@BraisGabin
Copy link
Member

Nice improvement

@schalkms schalkms merged commit 8eba28c into detekt:master Mar 30, 2020
@arturbosch arturbosch added this to the 1.7.3 milestone Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants