Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Rule: UnnecessarySafeCall #2574

Merged
merged 9 commits into from
Apr 4, 2020

Conversation

cortinico
Copy link
Member

@cortinico cortinico commented Apr 3, 2020

Adding the UnnecessarySafeCall rule, as suggested in #2572

@codecov-io
Copy link

codecov-io commented Apr 3, 2020

Codecov Report

Merging #2574 into master will increase coverage by 0.06%.
The diff coverage is 38.88%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2574      +/-   ##
============================================
+ Coverage     25.11%   25.17%   +0.06%     
- Complexity      392      393       +1     
============================================
  Files           378      378              
  Lines          7391     7399       +8     
  Branches       1221     1222       +1     
============================================
+ Hits           1856     1863       +7     
- Misses         5404     5405       +1     
  Partials        131      131              
Impacted Files Coverage Δ Complexity Δ
...rturbosch/detekt/rules/bugs/UnnecessarySafeCall.kt 35.29% <35.29%> (ø) 1.00 <1.00> (?)
...sch/detekt/rules/providers/PotentialBugProvider.kt 100.00% <100.00%> (ø) 2.00 <0.00> (ø)
...kotlin/io/gitlab/arturbosch/detekt/DetektPlugin.kt 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
.../arturbosch/detekt/internal/GradleProjectChecks.kt

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c19a2a7...ce99abf. Read the comment docs.

@cortinico cortinico changed the title Add the UnnecessarySafeCall rule New Rule: UnnecessarySafeCall Apr 4, 2020
cortinico and others added 6 commits April 4, 2020 02:52
…/bugs/UnnecessarySafeCall.kt

Co-Authored-By: M Schalk <30376729+schalkms@users.noreply.github.com>
…/bugs/UnnecessarySafeCallSpec.kt

Co-Authored-By: M Schalk <30376729+schalkms@users.noreply.github.com>
…/bugs/UnnecessarySafeCall.kt

Co-Authored-By: M Schalk <30376729+schalkms@users.noreply.github.com>
…/bugs/UnnecessarySafeCall.kt

Co-Authored-By: M Schalk <30376729+schalkms@users.noreply.github.com>
@schalkms schalkms merged commit d07b4bb into detekt:master Apr 4, 2020
@cortinico cortinico deleted the unnecessary-safe-call branch April 4, 2020 14:50
@arturbosch arturbosch added this to the 1.8.0 milestone Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants