Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExceptionRaisedInUnexpectedLocation>methodNames allow yaml list #2584

Merged
merged 3 commits into from
Apr 14, 2020
Merged

ExceptionRaisedInUnexpectedLocation>methodNames allow yaml list #2584

merged 3 commits into from
Apr 14, 2020

Conversation

BraisGabin
Copy link
Member

@BraisGabin BraisGabin commented Apr 6, 2020

This PR is one in a serie of PRs to implement #2498

We need to merge first #2583 because I need a commit from there.

@codecov-io
Copy link

codecov-io commented Apr 6, 2020

Codecov Report

Merging #2584 into master will increase coverage by 0.02%.
The diff coverage is 75.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2584      +/-   ##
============================================
+ Coverage     25.18%   25.20%   +0.02%     
  Complexity      395      395              
============================================
  Files           379      379              
  Lines          7422     7424       +2     
  Branches       1226     1226              
============================================
+ Hits           1869     1871       +2     
  Misses         5423     5423              
  Partials        130      130              
Impacted Files Coverage Δ Complexity Δ
.../exceptions/ExceptionRaisedInUnexpectedLocation.kt 58.33% <75.00%> (+8.33%) 1.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f38f16...8668b00. Read the comment docs.

Copy link
Member

@arturbosch arturbosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much nicer with the list syntax!

@BraisGabin BraisGabin marked this pull request as ready for review April 11, 2020 17:25
@BraisGabin BraisGabin added this to the 1.8.0 milestone Apr 11, 2020
@BraisGabin BraisGabin merged commit d68d83c into detekt:master Apr 14, 2020
@BraisGabin BraisGabin deleted the i2498-exception-raised-in-unexpected-locations branch April 14, 2020 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants