Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ForbiddenComment>values allow yaml list #2585

Merged
merged 3 commits into from
Apr 11, 2020
Merged

ForbiddenComment>values allow yaml list #2585

merged 3 commits into from
Apr 11, 2020

Conversation

BraisGabin
Copy link
Member

@BraisGabin BraisGabin commented Apr 6, 2020

This PR is one in a serie of PRs to implement #2498

We need to merge first #2583 because I need a commit from there.

@arturbosch arturbosch added this to the 1.8.0 milestone Apr 11, 2020
@BraisGabin BraisGabin marked this pull request as ready for review April 11, 2020 17:26
@codecov-io
Copy link

codecov-io commented Apr 11, 2020

Codecov Report

Merging #2585 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2585      +/-   ##
============================================
- Coverage     25.18%   25.17%   -0.01%     
  Complexity      395      395              
============================================
  Files           379      379              
  Lines          7422     7420       -2     
  Branches       1226     1225       -1     
============================================
- Hits           1869     1868       -1     
  Misses         5423     5423              
+ Partials        130      129       -1     
Impacted Files Coverage Δ Complexity Δ
.../arturbosch/detekt/rules/style/ForbiddenComment.kt 46.66% <100.00%> (-0.40%) 1.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f38f16...ba113c7. Read the comment docs.

@arturbosch arturbosch merged commit 434e25a into detekt:master Apr 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants