-
-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*>*Annotated* allow yaml lists #2587
Conversation
@Deprecated( | ||
message = "Use AnnotationExcluder(KtFile, List<String>) instead", | ||
replaceWith = ReplaceWith("AnnotationExcluder(root, excludes.mapAll { it })")) | ||
constructor(root: KtFile, excludes: SplitPattern) : this(root, excludes.mapAll { it }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe lets leave this constructor (not deprecating it) as we now have excludes.mapAll { it }
in four places?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The excludes.mapAll { it }
was an intermedieate step. You can check that in the final step I don't use SplitPattern
at all. My idea is that we can, deprecate SplitPattern
later. I think that I'm going to replace all its usages. But probably that's a decission for another PR. I will remove the Deprecated
for now.
Codecov Report
@@ Coverage Diff @@
## master #2587 +/- ##
============================================
+ Coverage 25.18% 25.24% +0.06%
Complexity 395 395
============================================
Files 379 379
Lines 7422 7430 +8
Branches 1226 1226
============================================
+ Hits 1869 1876 +7
- Misses 5423 5424 +1
Partials 130 130
Continue to review full report at Codecov.
|
This PR is one in a serie of PRs to implement #2498
We need to merge first #2583 because I need a commit from there.