Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*>*Annotated* allow yaml lists #2587

Merged
merged 6 commits into from
Apr 14, 2020
Merged

*>*Annotated* allow yaml lists #2587

merged 6 commits into from
Apr 14, 2020

Conversation

BraisGabin
Copy link
Member

@BraisGabin BraisGabin commented Apr 6, 2020

This PR is one in a serie of PRs to implement #2498

We need to merge first #2583 because I need a commit from there.

@Deprecated(
message = "Use AnnotationExcluder(KtFile, List<String>) instead",
replaceWith = ReplaceWith("AnnotationExcluder(root, excludes.mapAll { it })"))
constructor(root: KtFile, excludes: SplitPattern) : this(root, excludes.mapAll { it })
Copy link
Member

@arturbosch arturbosch Apr 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe lets leave this constructor (not deprecating it) as we now have excludes.mapAll { it } in four places?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The excludes.mapAll { it } was an intermedieate step. You can check that in the final step I don't use SplitPattern at all. My idea is that we can, deprecate SplitPattern later. I think that I'm going to replace all its usages. But probably that's a decission for another PR. I will remove the Deprecated for now.

@arturbosch arturbosch added this to the 1.8.0 milestone Apr 11, 2020
@codecov-io
Copy link

codecov-io commented Apr 11, 2020

Codecov Report

Merging #2587 into master will increase coverage by 0.06%.
The diff coverage is 63.15%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2587      +/-   ##
============================================
+ Coverage     25.18%   25.24%   +0.06%     
  Complexity      395      395              
============================================
  Files           379      379              
  Lines          7422     7430       +8     
  Branches       1226     1226              
============================================
+ Hits           1869     1876       +7     
- Misses         5423     5424       +1     
  Partials        130      130              
Impacted Files Coverage Δ Complexity Δ
...gitlab/arturbosch/detekt/api/AnnotationExcluder.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...bosch/detekt/rules/complexity/LongParameterList.kt 26.66% <33.33%> (+0.47%) 2.00 <0.00> (ø)
...tlab/arturbosch/detekt/rules/bugs/LateinitUsage.kt 42.85% <100.00%> (+2.85%) 1.00 <0.00> (ø)
...etekt/rules/style/FunctionOnlyReturningConstant.kt 30.00% <100.00%> (+5.00%) 1.00 <0.00> (ø)
...sch/detekt/rules/style/UnnecessaryAbstractClass.kt 23.91% <100.00%> (+3.45%) 1.00 <0.00> (ø)
...tlab/arturbosch/detekt/rules/style/UseDataClass.kt 15.78% <100.00%> (+1.50%) 1.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f38f16...5c90149. Read the comment docs.

@BraisGabin BraisGabin marked this pull request as ready for review April 11, 2020 17:27
@BraisGabin BraisGabin merged commit dba20e7 into detekt:master Apr 14, 2020
@BraisGabin BraisGabin deleted the i2498-lateinit-usage branch April 14, 2020 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants