Skip to content

Use more lintAndCompile #2601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 14, 2020
Merged

Use more lintAndCompile #2601

merged 7 commits into from
Apr 14, 2020

Conversation

BraisGabin
Copy link
Member

Blocked by #2600

lintAndCompile() only accepts a String as parameter. But we were using compileContentForTest(String) to generate a KtFile and using it to pass to lint().

In this PR I eliminate a lot of not needed calls to compileContentForTest so it's easier to move drom lint to lintAndCompile. I just moved the easiests ones in this PR, I didn't want to make it even bigger.

@codecov-io
Copy link

codecov-io commented Apr 13, 2020

Codecov Report

Merging #2601 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2601   +/-   ##
=========================================
  Coverage     25.20%   25.20%           
  Complexity      396      396           
=========================================
  Files           379      379           
  Lines          7427     7427           
  Branches       1225     1225           
=========================================
  Hits           1872     1872           
  Misses         5426     5426           
  Partials        129      129           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a93a46b...0721746. Read the comment docs.

@arturbosch arturbosch added this to the 1.8.0 milestone Apr 14, 2020
@BraisGabin BraisGabin marked this pull request as ready for review April 14, 2020 12:39
@BraisGabin BraisGabin merged commit e414f42 into detekt:master Apr 14, 2020
@BraisGabin BraisGabin deleted the lint-and-compile branch April 14, 2020 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants