Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report class and object violations at the identifier #2606

Merged
merged 1 commit into from
Apr 14, 2020

Conversation

arturbosch
Copy link
Member

Reporting them at the declaration itself will lead to highlighting the whole class/object with kdoc when post-processing the issue results. detekt/detekt-intellij-plugin#81

@arturbosch arturbosch added this to the 1.8.0 milestone Apr 14, 2020
Reporting them at the declaration itself will lead to highlighting the whole class/object with kdoc when post-processing the issue results. detekt/detekt-intellij-plugin#81
@arturbosch arturbosch added the migration Marker to add a migration step in the changelog label Apr 14, 2020
@codecov-io
Copy link

Codecov Report

Merging #2606 into master will increase coverage by 1.67%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2606      +/-   ##
============================================
+ Coverage     25.22%   26.89%   +1.67%     
+ Complexity      396      394       -2     
============================================
  Files           379      379              
  Lines          7429     6733     -696     
  Branches       1225     1224       -1     
============================================
- Hits           1874     1811      -63     
+ Misses         5426     4793     -633     
  Partials        129      129              
Impacted Files Coverage Δ Complexity Δ
...n/kotlin/io/gitlab/arturbosch/detekt/api/Entity.kt 62.50% <0.00%> (-4.17%) 0.00 <0.00> (ø)
...bosch/detekt/rules/bugs/EqualsWithHashCodeExist.kt 33.33% <0.00%> (+4.76%) 1.00 <0.00> (ø)
...etekt/rules/bugs/IteratorHasNextCallsNextMethod.kt 40.00% <0.00%> (+3.63%) 1.00 <0.00> (ø)
.../bugs/IteratorNotThrowingNoSuchElementException.kt 30.76% <0.00%> (+2.19%) 1.00 <0.00> (ø)
...tlab/arturbosch/detekt/rules/naming/ClassNaming.kt 54.54% <0.00%> (+4.54%) 1.00 <0.00> (ø)
...turbosch/detekt/rules/naming/ForbiddenClassName.kt 41.66% <0.00%> (+3.20%) 1.00 <0.00> (ø)
...bosch/detekt/rules/style/UnnecessaryInheritance.kt 37.50% <0.00%> (+7.50%) 1.00 <0.00> (ø)
...itlab/arturbosch/detekt/api/internal/Validation.kt 33.33% <0.00%> (-16.67%) 0.00% <0.00%> (ø%)
.../gitlab/arturbosch/detekt/cli/console/Colorizer.kt 61.53% <0.00%> (-9.90%) 0.00% <0.00%> (ø%)
...h/detekt/api/internal/DisabledAutoCorrectConfig.kt 55.55% <0.00%> (-8.09%) 4.00% <0.00%> (ø%)
... and 263 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb83202...ad1cd66. Read the comment docs.

Copy link
Member

@BraisGabin BraisGabin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@schalkms schalkms merged commit 2ee023d into master Apr 14, 2020
@schalkms schalkms deleted the report-at-identifier branch April 14, 2020 18:05
@pinkasey
Copy link
Contributor

@arturbosch that's great!
Would that work for TooManyFunctions in file as well?
For instance, I have several files like this in my codebase:
image

Also,
Can you tell when would this fix be released?

@arturbosch
Copy link
Member Author

Please open a new issue for TooManyFunctions. It is reported at the file level. We need to discuss if reporting it at the first line would be sufficient.

In the next days 1.8.0 will be released :)

@pinkasey
Copy link
Contributor

sure thing
Thanks!
detekt/detekt-intellij-plugin#83

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
migration Marker to add a migration step in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants