-
-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Report class and object violations at the identifier #2606
Conversation
a1095e3
to
b6e3fa5
Compare
Reporting them at the declaration itself will lead to highlighting the whole class/object with kdoc when post-processing the issue results. detekt/detekt-intellij-plugin#81
b6e3fa5
to
ad1cd66
Compare
Codecov Report
@@ Coverage Diff @@
## master #2606 +/- ##
============================================
+ Coverage 25.22% 26.89% +1.67%
+ Complexity 396 394 -2
============================================
Files 379 379
Lines 7429 6733 -696
Branches 1225 1224 -1
============================================
- Hits 1874 1811 -63
+ Misses 5426 4793 -633
Partials 129 129 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
@arturbosch that's great! Also, |
Please open a new issue for TooManyFunctions. It is reported at the file level. We need to discuss if reporting it at the first line would be sufficient. In the next days 1.8.0 will be released :) |
sure thing |
Reporting them at the declaration itself will lead to highlighting the whole class/object with kdoc when post-processing the issue results. detekt/detekt-intellij-plugin#81