Skip to content

Build detekt executable before publishing it - #2654 #2659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 7, 2020
Merged

Build detekt executable before publishing it - #2654 #2659

merged 1 commit into from
May 7, 2020

Conversation

arturbosch
Copy link
Member

@arturbosch arturbosch commented May 7, 2020 •
edited
Loading

Closes #2654

@arturbosch arturbosch added this to the 1.8.1 milestone May 7, 2020
schalkms
schalkms approved these changes May 7, 2020
View reviewed changes
Copy link
Member

@schalkms schalkms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

@codecov
Copy link

codecov bot commented May 7, 2020 •
edited
Loading

Codecov Report

Merging #2659 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2659   +/-   ##
=========================================
  Coverage     80.00%   80.00%           
  Complexity     2292     2292           
=========================================
  Files           379      379           
  Lines          6761     6761           
  Branches       1222     1222           
=========================================
  Hits           5409     5409           
  Misses          740      740           
  Partials        612      612

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57e745b...cbea1d8. Read the comment docs.

@schalkms schalkms merged commit a1d8391 into master May 7, 2020
@schalkms schalkms deleted the build-executable-when-before-publishing branch May 7, 2020 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BraisGabin BraisGabin BraisGabin approved these changes

@schalkms schalkms schalkms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.

Asset in release 1.8.0 is not up-to-date
3 participants
@arturbosch @BraisGabin @schalkms