Remove duplicate MandatoryBracesLoops rule tests #2665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since both the types for and while use the same logic to detect missing braces, we don't need to duplicate all tests for both.
Codecov Report
@@ Coverage Diff @@
## master #2665 +/- ##
=========================================
Coverage 79.97% 79.97%
Complexity 2303 2303
=========================================
Files 380 380
Lines 6771 6771
Branches 1225 1225
=========================================
Hits 5415 5415
Misses 740 740
Partials 616 616 Continue to review full report at Codecov.
|
BraisGabin
approved these changes
May 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since both the types for and while use the same logic to detect missing braces, we don't need to duplicate all tests for both.