Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include Kotlin multiplatform test folders to default exclude config #2667

Merged
merged 2 commits into from
May 9, 2020
Merged

Include Kotlin multiplatform test folders to default exclude config #2667

merged 2 commits into from
May 9, 2020

Conversation

schalkms
Copy link
Member

@schalkms schalkms commented May 9, 2020

Closes #2608

@codecov
Copy link

codecov bot commented May 9, 2020 •
edited
Loading

Codecov Report

Merging #2667 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2667   +/-   ##
=========================================
  Coverage     79.98%   79.98%           
  Complexity     2303     2303           
=========================================
  Files           380      380           
  Lines          6770     6770           
  Branches       1224     1224           
=========================================
  Hits           5415     5415           
  Misses          740      740           
  Partials        615      615
Impacted Files Coverage Δ Complexity Δ
...kt/generator/printer/rulesetpage/TestExclusions.kt 93.33% <ø> (ø) 4.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c712918...119da22. Read the comment docs.

BraisGabin
BraisGabin approved these changes May 9, 2020
View reviewed changes
Copy link
Member

@BraisGabin BraisGabin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Man, we really need #2581 this list is growing too much

.../src/main/kotlin/io/gitlab/arturbosch/detekt/generator/printer/rulesetpage/TestExclusions.kt Outdated Show resolved Hide resolved
@BraisGabin BraisGabin mentioned this pull request May 9, 2020
Closed
@schalkms schalkms merged commit 070e641 into detekt:master May 9, 2020
@schalkms schalkms deleted the #2608-excludesconf branch May 9, 2020 16:12
@arturbosch arturbosch added this to the 1.8.1 milestone May 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BraisGabin BraisGabin BraisGabin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.

Include Kotlin multiplatform test folders to default exclude configuration
3 participants
@schalkms @BraisGabin @arturbosch