Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify patterns #2668

Merged
merged 2 commits into from
May 9, 2020
Merged

Simplify patterns #2668

merged 2 commits into from
May 9, 2020

Conversation

BraisGabin
Copy link
Member

We are using ^ and $ to match the start or end of a String but we don't need it. We are using .matches that ensure that we are maching all the String.

@codecov
Copy link

codecov bot commented May 9, 2020

Codecov Report

Merging #2668 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2668   +/-   ##
=========================================
  Coverage     79.98%   79.98%           
  Complexity     2303     2303           
=========================================
  Files           380      380           
  Lines          6770     6770           
  Branches       1224     1224           
=========================================
  Hits           5415     5415           
  Misses          740      740           
  Partials        615      615           
Impacted Files Coverage Δ Complexity Δ
...kt/generator/printer/rulesetpage/TestExclusions.kt 93.33% <ø> (ø) 4.00 <0.00> (ø)
...rbosch/detekt/rules/AllowedExceptionNamePattern.kt 0.00% <ø> (ø) 0.00 <0.00> (ø)
...b/arturbosch/detekt/rules/empty/EmptyCatchBlock.kt 88.88% <ø> (ø) 3.00 <0.00> (ø)
...osch/detekt/rules/exceptions/SwallowedException.kt 71.73% <ø> (ø) 17.00 <0.00> (ø)
...tekt/rules/exceptions/TooGenericExceptionCaught.kt 86.95% <ø> (ø) 5.00 <0.00> (ø)
...itlab/arturbosch/detekt/rules/naming/EnumNaming.kt 90.90% <100.00%> (ø) 4.00 <0.00> (ø)
...ab/arturbosch/detekt/rules/naming/PackageNaming.kt 100.00% <100.00%> (ø) 6.00 <0.00> (ø)
...detekt/rules/style/UnderscoresInNumericLiterals.kt 83.33% <100.00%> (ø) 12.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 070e641...62b1034. Read the comment docs.

@schalkms schalkms merged commit db09a74 into detekt:master May 9, 2020
@arturbosch arturbosch added this to the 1.8.1 milestone May 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants