Extra documentation added to pitfalls section #2675
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2675 +/- ##
=========================================
Coverage 79.48% 79.48%
Complexity 2293 2293
=========================================
Files 380 380
Lines 6781 6781
Branches 1229 1229
=========================================
Hits 5390 5390
Misses 774 774
Partials 617 617 Continue to review full report at Codecov.
|
schalkms
approved these changes
May 11, 2020
arturbosch
approved these changes
May 11, 2020
|
Thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added some confusing points to the documentation.
These are discussed in:
#2663
#2645 (comment)