Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report a better message for LongParameterList #2684

Merged
merged 1 commit into from
May 13, 2020
Merged

Report a better message for LongParameterList #2684

merged 1 commit into from
May 13, 2020

Conversation

schalkms
Copy link
Member

The reported message now differs between a function and a constructor with a too long parameter list.

The reported message now differs between a function and a constructor with a too long parameter list.
Copy link
Member

@BraisGabin BraisGabin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not directly related with this PR but it would be great to say the current number of parameters in the message.

@codecov
Copy link

codecov bot commented May 13, 2020

Codecov Report

Merging #2684 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2684      +/-   ##
============================================
- Coverage     79.50%   79.50%   -0.01%     
  Complexity     2293     2293              
============================================
  Files           380      380              
  Lines          6782     6781       -1     
  Branches       1229     1229              
============================================
- Hits           5392     5391       -1     
  Misses          774      774              
  Partials        616      616              
Impacted Files Coverage Δ Complexity Δ
...bosch/detekt/rules/complexity/LongParameterList.kt 86.84% <100.00%> (-0.34%) 23.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89a0fbf...1189b66. Read the comment docs.

@schalkms schalkms merged commit a1106a5 into detekt:master May 13, 2020
@schalkms schalkms deleted the LongParameterList-message branch May 13, 2020 19:12
@arturbosch arturbosch added this to the 1.9.1 milestone May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants