Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix serialVersionUID false positive in UnderscoresInNumericLiteral #2687

Merged
merged 2 commits into from
May 14, 2020
Merged

Fix serialVersionUID false positive in UnderscoresInNumericLiteral #2687

merged 2 commits into from
May 14, 2020

Conversation

schalkms
Copy link
Member

This fixes the cases where a serialVersionUID

  1. has either a negative number
  2. is inside a companion object
  3. or both

Closes #2686

This fixes the cases where a serialVersionUID
1. has either a negative number
2. is inside a companion object
3. or both

Closes #2686
@codecov
Copy link

codecov bot commented May 14, 2020

Codecov Report

Merging #2687 into master will increase coverage by 0.00%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2687   +/-   ##
=========================================
  Coverage     79.50%   79.50%           
- Complexity     2293     2301    +8     
=========================================
  Files           380      380           
  Lines          6781     6788    +7     
  Branches       1229     1233    +4     
=========================================
+ Hits           5391     5397    +6     
  Misses          774      774           
- Partials        616      617    +1     
Impacted Files Coverage Δ Complexity Δ
...detekt/rules/style/UnderscoresInNumericLiterals.kt 82.14% <71.42%> (-1.20%) 20.00 <9.00> (+8.00) ⬇️
...bosch/detekt/rules/complexity/LongParameterList.kt 87.80% <0.00%> (+0.96%) 23.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1106a5...03bb7b0. Read the comment docs.

@schalkms schalkms merged commit f3994d3 into detekt:master May 14, 2020
@schalkms schalkms deleted the fix-#2686-UnderscoresInNumericLiterals branch May 14, 2020 19:24
@arturbosch arturbosch added this to the 1.9.1 milestone May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive UnderscoresInNumericLiterals in Serializable
3 participants