Skip to content

Fix wrong test cases for CollapsibleIfs rule #2694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2020
Merged

Fix wrong test cases for CollapsibleIfs rule #2694

merged 1 commit into from
May 15, 2020

Conversation

schalkms
Copy link
Member

The test case was wrong due to the code reformatting happening in commit 445ffb0.

The test case was wrong due to the code reformatting happening in commit 445ffb0.
Copy link
Member

@BraisGabin BraisGabin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another reason to inline all our snippets. Good catch!

@codecov
Copy link

codecov bot commented May 15, 2020

Codecov Report

Merging #2694 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2694   +/-   ##
=========================================
  Coverage     79.60%   79.60%           
  Complexity     2303     2303           
=========================================
  Files           381      381           
  Lines          6856     6856           
  Branches       1245     1245           
=========================================
  Hits           5458     5458           
  Misses          779      779           
  Partials        619      619           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7e6992...5590e02. Read the comment docs.

@schalkms schalkms merged commit ddfc8a3 into detekt:master May 15, 2020
@schalkms schalkms deleted the fix-test-cases-CollapsibleIfs branch May 15, 2020 09:40
@arturbosch arturbosch added this to the 1.9.1 milestone May 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants