Skip to content

Clean up code by using builtin associateBy function #2715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2020
Merged

Conversation

arturbosch
Copy link
Member

No description provided.

@github-actions
Copy link

Warnings
⚠️

detekt-cli/src/main/kotlin/io/gitlab/arturbosch/detekt/cli/OutputFacade.kt#L27 - Type checking is a sign of violating the Open-Closed Principle. Consider introducing an abstraction (interface) for OutputReport, ConsoleReport, with new implementations of the interface for every class.

Generated by 🚫 Danger Kotlin against 0d0e23e

@codecov
Copy link

codecov bot commented May 21, 2020

Codecov Report

Merging #2715 into master will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2715      +/-   ##
============================================
+ Coverage     80.52%   80.57%   +0.04%     
- Complexity     2322     2323       +1     
============================================
  Files           378      378              
  Lines          6944     6940       -4     
  Branches       1258     1257       -1     
============================================
  Hits           5592     5592              
+ Misses          725      721       -4     
  Partials        627      627              
Impacted Files Coverage Δ Complexity Δ
...ain/kotlin/io/gitlab/arturbosch/detekt/cli/Junk.kt 100.00% <ø> (+66.66%) 0.00 <0.00> (ø)
...in/io/gitlab/arturbosch/detekt/cli/OutputFacade.kt 94.44% <100.00%> (ø) 7.00 <3.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5926d84...0d0e23e. Read the comment docs.

@detekt detekt deleted a comment from github-actions bot May 21, 2020
@arturbosch
Copy link
Member Author

Warnings

detekt-cli/src/main/kotlin/io/gitlab/arturbosch/detekt/cli/OutputFacade.kt#L27 - Type checking is a sign of violating the Open-Closed Principle. Consider introducing an abstraction (interface) for OutputReport, ConsoleReport, with new implementations of the interface for every class.

Generated by Danger Kotlin against 0d0e23e

Jap, its bad design here.

@arturbosch arturbosch merged commit fd77ea8 into master May 21, 2020
@arturbosch arturbosch deleted the cleanup1 branch May 21, 2020 20:10
@arturbosch arturbosch added the housekeeping Marker for housekeeping tasks and refactorings label Jun 4, 2020
@arturbosch arturbosch added this to the 1.10.0 milestone Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Marker for housekeeping tasks and refactorings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants