Merged
Conversation
BraisGabin
approved these changes
May 24, 2020
| @@ -31,7 +31,7 @@ private fun getGradleVersionsUnderTest() = | |||
| if (getJdkVersion() < 13) { | |||
| listOf("5.0", "6.2.2") | |||
Member
There was a problem hiding this comment.
Shouldn't we upgrade this one too?
Member
Author
There was a problem hiding this comment.
It's the last Gradle version which does not support Java 13+, so we can't update this one.
Member
Author
There was a problem hiding this comment.
Maybe I'm wrong here. Just tested it. Locally it works. I've merged @schalkms suggestion and see what the CI says.
cortinico
requested changes
May 24, 2020
Codecov Report
@@ Coverage Diff @@
## master #2729 +/- ##
============================================
- Coverage 80.58% 80.53% -0.06%
+ Complexity 2317 2310 -7
============================================
Files 379 379
Lines 6960 6960
Branches 1260 1260
============================================
- Hits 5609 5605 -4
- Misses 724 728 +4
Partials 627 627
Continue to review full report at Codecov.
|
schalkms
approved these changes
May 24, 2020
detekt-gradle-plugin/src/test/kotlin/io/gitlab/arturbosch/detekt/MultiVersionTest.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Nicola Corti <corti.nico@gmail.com>
…kt/MultiVersionTest.kt Co-authored-by: M Schalk <30376729+schalkms@users.noreply.github.com>
cortinico
approved these changes
May 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.