Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make baseline entities internal #2740

Merged
merged 3 commits into from
May 28, 2020
Merged

Make baseline entities internal #2740

merged 3 commits into from
May 28, 2020

Conversation

arturbosch
Copy link
Member

Needs #2739 to merge first.

@codecov
Copy link

codecov bot commented May 27, 2020

Codecov Report

Merging #2740 into master will not change coverage.
The diff coverage is 90.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2740   +/-   ##
=========================================
  Coverage     80.50%   80.50%           
+ Complexity     2310     2309    -1     
=========================================
  Files           378      377    -1     
  Lines          6962     6962           
  Branches       1262     1262           
=========================================
  Hits           5605     5605           
  Misses          728      728           
  Partials        629      629           
Impacted Files Coverage Δ Complexity Δ
...b/arturbosch/detekt/cli/baseline/BaselineFormat.kt 83.33% <75.00%> (+0.72%) 4.00 <1.00> (ø)
.../gitlab/arturbosch/detekt/cli/baseline/Baseline.kt 66.66% <100.00%> (ø) 4.00 <1.00> (ø)
...osch/detekt/cli/baseline/BaselineFilteredResult.kt 100.00% <100.00%> (ø) 3.00 <2.00> (ø)
...h/detekt/cli/baseline/DelegatingXMLStreamWriter.kt 100.00% <100.00%> (ø) 1.00 <1.00> (ø)
...ch/detekt/cli/baseline/IndentingXMLStreamWriter.kt 60.37% <100.00%> (ø) 15.00 <1.00> (ø)
...ab/arturbosch/detekt/cli/baseline/XmlExtensions.kt 23.52% <100.00%> (ø) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afebefc...87b4ae8. Read the comment docs.

@arturbosch arturbosch merged commit 6907704 into master May 28, 2020
@arturbosch arturbosch deleted the internal-baseline branch May 28, 2020 22:14
@arturbosch arturbosch added this to the 1.10.0 milestone Jun 4, 2020
@arturbosch arturbosch added the housekeeping Marker for housekeeping tasks and refactorings label Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Marker for housekeeping tasks and refactorings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant