Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move baseline feature to core module #2741

Merged
merged 1 commit into from
May 29, 2020
Merged

Move baseline feature to core module #2741

merged 1 commit into from
May 29, 2020

Conversation

arturbosch
Copy link
Member

Needs two previous PRs to be merged first.

Towards a minimal cli and a common core module #2680

@codecov
Copy link

codecov bot commented May 27, 2020

Codecov Report

Merging #2741 into master will decrease coverage by 0.02%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2741      +/-   ##
============================================
- Coverage     80.50%   80.48%   -0.03%     
  Complexity     2309     2309              
============================================
  Files           377      377              
  Lines          6962     6959       -3     
  Branches       1262     1262              
============================================
- Hits           5605     5601       -4     
  Misses          728      728              
- Partials        629      630       +1     
Impacted Files Coverage Δ Complexity Δ
.../io/gitlab/arturbosch/detekt/cli/runners/Runner.kt 89.36% <0.00%> (-2.80%) 9.00 <0.00> (-1.00)
...gitlab/arturbosch/detekt/core/baseline/Baseline.kt 66.66% <ø> (ø) 4.00 <0.00> (?)
...sch/detekt/core/baseline/BaselineFilteredResult.kt 100.00% <ø> (ø) 3.00 <0.00> (?)
.../arturbosch/detekt/core/baseline/BaselineFormat.kt 83.33% <ø> (ø) 4.00 <0.00> (?)
...arturbosch/detekt/core/baseline/BaselineHandler.kt 76.47% <ø> (ø) 14.00 <0.00> (?)
.../detekt/core/baseline/DelegatingXMLStreamWriter.kt 100.00% <ø> (ø) 1.00 <0.00> (?)
...h/detekt/core/baseline/IndentingXMLStreamWriter.kt 60.37% <ø> (ø) 15.00 <0.00> (?)
...b/arturbosch/detekt/core/baseline/XmlExtensions.kt 23.52% <ø> (ø) 0.00 <0.00> (?)
.../arturbosch/detekt/core/baseline/BaselineFacade.kt 77.77% <100.00%> (ø) 6.00 <1.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6907704...55d0b06. Read the comment docs.

First step towards a minimal cli module.
@arturbosch arturbosch marked this pull request as ready for review May 28, 2020 22:26
@@ -38,7 +36,7 @@ class Runner(
var (engineRunTime, result) = measure { facade.run() }
settings.debug { "Running core engine took $engineRunTime ms" }
checkBaselineCreation(result)
result = transformResult(result)
result = arguments.baseline?.let { BaselineFacade().transformResult(it, result) } ?: result
Copy link
Member Author

@arturbosch arturbosch May 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not super nice but gets the job done for now. I will further refactor this in a later PR.

@arturbosch arturbosch merged commit 5c73ccd into master May 29, 2020
@arturbosch arturbosch deleted the baseline-to-core branch May 29, 2020 08:45
@arturbosch arturbosch added this to the 1.10.0 milestone Jun 4, 2020
@arturbosch arturbosch added the housekeeping Marker for housekeeping tasks and refactorings label Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Marker for housekeeping tasks and refactorings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants