-
-
Notifications
You must be signed in to change notification settings - Fork 767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move baseline feature to core module #2741
Conversation
5b01ee0
to
10f42d7
Compare
Codecov Report
@@ Coverage Diff @@
## master #2741 +/- ##
============================================
- Coverage 80.50% 80.48% -0.03%
Complexity 2309 2309
============================================
Files 377 377
Lines 6962 6959 -3
Branches 1262 1262
============================================
- Hits 5605 5601 -4
Misses 728 728
- Partials 629 630 +1
Continue to review full report at Codecov.
|
First step towards a minimal cli module.
10f42d7
to
55d0b06
Compare
@@ -38,7 +36,7 @@ class Runner( | |||
var (engineRunTime, result) = measure { facade.run() } | |||
settings.debug { "Running core engine took $engineRunTime ms" } | |||
checkBaselineCreation(result) | |||
result = transformResult(result) | |||
result = arguments.baseline?.let { BaselineFacade().transformResult(it, result) } ?: result |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not super nice but gets the job done for now. I will further refactor this in a later PR.
Needs two previous PRs to be merged first.
Towards a minimal cli and a common core module #2680