Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark some well known cli functions as implicit unsupported api #2742

Merged
merged 1 commit into from
May 28, 2020

Conversation

arturbosch
Copy link
Member

@arturbosch arturbosch commented May 27, 2020

Not sure if necessary but may help to remind us to not break these functions in further refactorings.

@codecov
Copy link

codecov bot commented May 27, 2020

Codecov Report

Merging #2742 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2742   +/-   ##
=========================================
  Coverage     80.59%   80.59%           
  Complexity     2315     2315           
=========================================
  Files           380      380           
  Lines          6976     6976           
  Branches       1260     1260           
=========================================
  Hits           5622     5622           
  Misses          728      728           
  Partials        626      626           
Impacted Files Coverage Δ Complexity Δ
.../io/gitlab/arturbosch/detekt/cli/Configurations.kt 76.47% <ø> (ø) 0.00 <0.00> (ø)
...ain/kotlin/io/gitlab/arturbosch/detekt/cli/Main.kt 31.81% <ø> (ø) 5.00 <0.00> (ø)
.../io/gitlab/arturbosch/detekt/cli/runners/Runner.kt 94.00% <ø> (ø) 10.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 664e734...1ec31ff. Read the comment docs.

Copy link
Member

@schalkms schalkms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

Copy link
Member

@BraisGabin BraisGabin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this! It also help us to know what to hide in 2.0

@arturbosch
Copy link
Member Author

Cool that it is helpful :)

@arturbosch arturbosch merged commit 0601a86 into master May 28, 2020
@arturbosch arturbosch deleted the implicit-api branch May 28, 2020 22:03
@arturbosch arturbosch added this to the 1.10.0 milestone Jun 4, 2020
@arturbosch arturbosch added the housekeeping Marker for housekeeping tasks and refactorings label Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Marker for housekeeping tasks and refactorings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants