Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EqualsAlwaysReturnsTrueOrFalse doc #2744

Merged
merged 2 commits into from
May 28, 2020
Merged

Fix EqualsAlwaysReturnsTrueOrFalse doc #2744

merged 2 commits into from
May 28, 2020

Conversation

hqzxzwb
Copy link
Contributor

@hqzxzwb hqzxzwb commented May 28, 2020

Use == in equals causes infinite recursion.

Use `==` in equals causes infinite recursion.
@codecov
Copy link

codecov bot commented May 28, 2020

Codecov Report

Merging #2744 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2744   +/-   ##
=========================================
  Coverage     80.59%   80.59%           
  Complexity     2315     2315           
=========================================
  Files           380      380           
  Lines          6976     6976           
  Branches       1260     1260           
=========================================
  Hits           5622     5622           
  Misses          728      728           
  Partials        626      626           
Impacted Files Coverage Δ Complexity Δ
...etekt/rules/bugs/EqualsAlwaysReturnsTrueOrFalse.kt 86.95% <ø> (ø) 14.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 664e734...c8eba58. Read the comment docs.

@cortinico
Copy link
Member

Thanks for the fix @hqzxzwb You need to run ./gradlew build as the documentation will be re-generated and should be attached to the diff, otherwise the CI will fail.

Copy link
Member

@schalkms schalkms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big Thanks!

@schalkms schalkms merged commit 39b0864 into detekt:master May 28, 2020
@arturbosch arturbosch added this to the 1.10.0 milestone May 28, 2020
schalkms added a commit that referenced this pull request May 30, 2020
@arturbosch arturbosch added the housekeeping Marker for housekeeping tasks and refactorings label Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Marker for housekeeping tasks and refactorings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants