Add default print methods to ForbiddenMethodCall #2753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding all the variations of print/println from Java and Kotlin to the ForbiddenMethodCall. The rationale is to encourage the usage of a Logger. Moreover this fixes the rule that was not catching all the method calls due to overriding visitQualifiedExpression rather than visitCallExpression Fixes detekt#2678
Codecov Report
@@ Coverage Diff @@
## master #2753 +/- ##
============================================
- Coverage 80.44% 80.43% -0.01%
Complexity 2303 2303
============================================
Files 379 379
Lines 6943 6946 +3
Branches 1261 1261
============================================
+ Hits 5585 5587 +2
Misses 729 729
- Partials 629 630 +1
Continue to review full report at Codecov.
|
schalkms
approved these changes
May 31, 2020
detekt-rules/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/style/ForbiddenMethodCallSpec.kt
Outdated
Show resolved
Hide resolved
schalkms
approved these changes
May 31, 2020
arturbosch
approved these changes
May 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding all the variations of print/println from Java
to the ForbiddenMethodCall.
The rationale is to encourage the usage of a Logger or a PrintStream
Moreover this fixes the rule that was not catching all the method
calls due to overriding visitQualifiedExpression rather than visitCallExpression
Fixes #2678