Wrap three new experimental KtLint rules #2762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arturbosch
commented
Jun 3, 2020
|
|
||
| ### SpacingBetweenDeclarationsWithComments | ||
|
|
||
| See <a href="https://ktlint.github.io/#rule-spacing">ktlint-website</a> for documentation. |
There was a problem hiding this comment.
Note that KtLint does not update their website with new examples.
There was a problem hiding this comment.
Where to they document the behavior then?
There was a problem hiding this comment.
Then we should maybe link the source code or at least the package?
There was a problem hiding this comment.
Good idea, just checked only the ImportOrdering had this extensive documentation (which I already linked in the PR).
The other three rules not. Just a link to youtrack which is basically the same amount of information as the issue description we report :).
It won't help much to include the a link to youtrack or the ktlint rule...
schalkms
approved these changes
Jun 3, 2020
|
|
||
| ### SpacingBetweenDeclarationsWithComments | ||
|
|
||
| See <a href="https://ktlint.github.io/#rule-spacing">ktlint-website</a> for documentation. |
There was a problem hiding this comment.
Where to they document the behavior then?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.