Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support layout property for ImportOrdering rule #2763

Merged
merged 2 commits into from
Jun 4, 2020

Conversation

arturbosch
Copy link
Member

@arturbosch arturbosch commented Jun 3, 2020

Looks like we should not rush in a release featuring 0.37.0

pinterest/ktlint#761
pinterest/ktlint#682

I plan to prepare a release candidate 1.10.0-RC1 in the next days as we have many refactorings in this one.

@arturbosch arturbosch added this to the 1.10.0 milestone Jun 3, 2020
@codecov
Copy link

codecov bot commented Jun 3, 2020

Codecov Report

Merging #2763 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2763      +/-   ##
============================================
+ Coverage     80.47%   80.49%   +0.01%     
- Complexity     2309     2314       +5     
============================================
  Files           380      381       +1     
  Lines          6936     6937       +1     
  Branches       1254     1255       +1     
============================================
+ Hits           5582     5584       +2     
+ Misses          728      727       -1     
  Partials        626      626              
Impacted Files Coverage Δ Complexity Δ
...urbosch/detekt/formatting/EditorConfigConstants.kt 100.00% <100.00%> (ø) 0.00 <0.00> (?)
.../arturbosch/detekt/formatting/EditorConfigMerge.kt 83.33% <100.00%> (-8.98%) 0.00 <0.00> (ø)
...urbosch/detekt/formatting/wrappers/FinalNewline.kt 100.00% <100.00%> (ø) 4.00 <0.00> (ø)
...bosch/detekt/formatting/wrappers/ImportOrdering.kt 100.00% <100.00%> (ø) 7.00 <3.00> (+5.00)
...turbosch/detekt/formatting/wrappers/Indentation.kt 100.00% <100.00%> (ø) 4.00 <0.00> (ø)
...ch/detekt/formatting/wrappers/MaximumLineLength.kt 88.88% <100.00%> (ø) 5.00 <0.00> (ø)
...etekt/formatting/wrappers/ParameterListWrapping.kt 100.00% <100.00%> (ø) 4.00 <0.00> (ø)
...lin/io/gitlab/arturbosch/detekt/api/ConfigAware.kt 66.66% <0.00%> (+11.11%) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c86f1d0...96afa67. Read the comment docs.

@schalkms
Copy link
Member

schalkms commented Jun 3, 2020

I plan to prepare a release candidate 1.10.0-RC1 in the next days as we have many refactorings in this one.

Have you tested this recent changes thoroughly? I don't think it's a good idea to let the client/user find out breaking stuff.

@arturbosch
Copy link
Member Author

I plan to prepare a release candidate 1.10.0-RC1 in the next days as we have many refactorings in this one.

Have you tested this recent changes thoroughly? I don't think it's a good idea to let the client/user find out breaking stuff.

Yes, while refactoring and will do more :).

@arturbosch arturbosch merged commit cd4ca7f into master Jun 4, 2020
@arturbosch arturbosch deleted the support-import-order branch June 4, 2020 05:05
@samramez
Copy link

How can we find examples on how we're suppose to use the layout property?

@schalkms
Copy link
Member

@samramez yes, there is documentation available on the homepage. You can configure it in the detekt.yml file.
What exactly do you find missing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants