Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update spek to 2.0.11 disabling timeouts #2767

Merged
merged 1 commit into from
Jun 5, 2020
Merged

Update spek to 2.0.11 disabling timeouts #2767

merged 1 commit into from
Jun 5, 2020

Conversation

arturbosch
Copy link
Member

No description provided.

@arturbosch arturbosch added the housekeeping Marker for housekeeping tasks and refactorings label Jun 4, 2020
@arturbosch arturbosch added this to the 1.10.0 milestone Jun 4, 2020
@codecov
Copy link

codecov bot commented Jun 4, 2020

Codecov Report

Merging #2767 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2767   +/-   ##
=========================================
  Coverage     80.53%   80.53%           
  Complexity     2319     2319           
=========================================
  Files           385      385           
  Lines          6961     6961           
  Branches       1261     1261           
=========================================
  Hits           5606     5606           
  Misses          727      727           
  Partials        628      628

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92acdbc...331b372. Read the comment docs.

BraisGabin
BraisGabin approved these changes Jun 4, 2020
View reviewed changes
Copy link
Member

@BraisGabin BraisGabin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

disabling timeouts?

schalkms
schalkms approved these changes Jun 4, 2020
View reviewed changes
Copy link
Member

@schalkms schalkms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean by that?

disabling timeouts

@arturbosch
Copy link
Member Author

Oh sorry.
Spek removed the default timeout of 10 seconds which leads to failing tests when debugging on IntelliJ.
They are getting back to it when they find a way to turn this off only on IDE.

@arturbosch arturbosch merged commit 7214870 into master Jun 5, 2020
@arturbosch arturbosch deleted the update-spek branch June 5, 2020 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schalkms schalkms schalkms approved these changes

@BraisGabin BraisGabin BraisGabin approved these changes

Assignees
No one assigned
Labels
housekeeping Marker for housekeeping tasks and refactorings
Projects
None yet
Milestone
1.10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@arturbosch @BraisGabin @schalkms