Remove core module dependency for detekt-test #2771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arturbosch
commented
Jun 4, 2020
detekt-core/src/test/kotlin/io/gitlab/arturbosch/detekt/core/CorrectableRulesFirstSpec.kt
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #2771 +/- ##
=========================================
Coverage 80.53% 80.53%
Complexity 2321 2321
=========================================
Files 386 386
Lines 6952 6952
Branches 1260 1260
=========================================
Hits 5599 5599
Misses 725 725
Partials 628 628 Continue to review full report at Codecov.
|
Besides of one usage in formatting it is only used by the core module. Custom rule sets (formatting is treated as one) should not depend on core.
…ules We merge the service loaders when constructing the cli shadowJar. When combining jars dynamically this is not an issue as each jar has it's own services file.
arturbosch
force-pushed
the
detekt-test-core-free
branch
from
43e0881 to
2b8bde6
Compare
schalkms
approved these changes
Jun 5, 2020
detekt-test/src/main/kotlin/io/gitlab/arturbosch/detekt/test/RuleSetExtensions.kt
Outdated
Show resolved
Hide resolved
…uleSetExtensions.kt Co-authored-by: M Schalk <30376729+schalkms@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Results in earlier execution of test tasks for all modules -> better parallalization.
I think we should enable caching and parallel builds by default for everyone in gradle.properties.
I'm using both for months and it is amazing :)